Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ESRI Dynamic): raster layers in ESRI Dynamic geocore layers now load #2670

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Dec 20, 2024

Closes #2598

Description

Fixes issue with raster layers not loading in ESRI Dynamic geocore layers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/add-layers.html

06be2cfe-d334-4f92-94ae-62a7615e9d28 -fixed
5095a5e0-e574-4769-84d3-acaac529399b - fixed
37b59b8b-1c1c-4869-802f-c09571cc984b - fixed
3d52693e-39d1-4e7f-b4fa-b72ccb605006 - fixed
42478434-e0ac-4f40-a4ac-aec40f161a9c - fixed
c094782e-0d6f-4cc0-b5a3-58908493a433 - fixed
ac2096a6-7b4a-464e-9e08-eca7873dd88c - fixed
47a60179-83aa-4750-ad59-5797da909748 - all layers load, layers 0 and 17 are in RCS but don't exist, and two layers have no legend (15 and 16) - does not load at all in RAMP
6c7e9bb6-17e1-4e41-b49c-23261c8eefbc - fixed
bd71df53-543d-4359-9d17-8f1bb3b5ab90 - fixed

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq December 20, 2024 18:53
@DamonU2 DamonU2 self-assigned this Dec 20, 2024
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 58543d5 into Canadian-Geospatial-Platform:develop Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 10 - Raster layers in esriDynamic services fail to load [OSDP-1801] (10 layers)
2 participants